gh-153182: Explicitly return NULL when new_keys_object call fails in _PyDict_NewKeysForClass#153183
Closed
stestagg wants to merge 1 commit into
Closed
gh-153182: Explicitly return NULL when new_keys_object call fails in _PyDict_NewKeysForClass#153183stestagg wants to merge 1 commit into
new_keys_object call fails in _PyDict_NewKeysForClass#153183stestagg wants to merge 1 commit into
Conversation
…ails in `_PyDict_NewKeysForClass` to prevent a segfault when subsequent code tries to use the returned object
methane
approved these changes
Jul 6, 2026
Contributor
Author
|
Thanks @methane! |
kumaraditya303
approved these changes
Jul 7, 2026
Contributor
|
There is a merge conflict. |
Contributor
Author
|
Thanks @kumaraditya303. It looks like this PR: Also made this change, so this is now defunct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a segfault when code further down the function tries to populate
keyswith the contents of__static_attributes__